Fix JAX empty assignment indices#3627
Open
FlorianPfaff wants to merge 2 commits into
Open
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assignmentandassignment_by_sumwith a backend-portable regression test.Bug fixed
The raw JAX assignment helpers normalized an empty index sequence such as
[]into a vectorized full-axis slice. As a result,assignment([1, 2, 3], 99, [])could overwrite the whole vector andassignment_by_sum([1, 2, 3], 99, [])could add to every element instead of leaving the input unchanged. The NumPy/PyTorch backends already treat empty index sequences as no-ops.Validation
tests/backend_support/test_jax_assignment_empty_indices_contract.py.main.